Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed stamp.bzl missing form @rules_python//:bzl target. #560

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Fixed stamp.bzl missing form @rules_python//:bzl target. #560

merged 1 commit into from
Oct 26, 2021

Conversation

UebelAndre
Copy link
Contributor

@UebelAndre UebelAndre commented Oct 26, 2021 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • Does not include precompiled binaries, eg. .par files. See CONTRIBUTING.md for info
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Following #554, a regression was introduced that broke the ability to generate docs via stardoc. This PR fixes that.

Issue Number: #561

What is the new behavior?

This allows users to continue to generate docs after release 0.5.0

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla google-cla bot added the cla: yes label Oct 26, 2021
@alexeagle alexeagle merged commit 1a79c2a into bazelbuild:main Oct 26, 2021
@UebelAndre UebelAndre deleted the bzl branch October 26, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@brandjon brandjon Awaiting requested review from brandjon

@lberki lberki Awaiting requested review from lberki

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UebelAndre @alexeagle